fix(build.gradle.kts): add test source directory for annotation#321
Conversation
|
Warning Review limit reached
More reviews will be available in 12 minutes and 12 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Gradle build script for the Java SDK registers the annotation-processor-generated test Java sources directory ( ChangesJava SDK Build Script
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
pratyush618
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
sdks/java/build.gradle.kts (1)
81-83: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick winRemove the generated test sources directory from
sourceSets["test"].
testAnnotationProcessoralready makes this output available tocompileTestJava; keeping it in the test source set is redundant and can interfere with incremental builds/IDE import. If IDE visibility is the goal, mark it as a generated source root instead.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@sdks/java/build.gradle.kts` around lines 81 - 83, Remove the generated test sources directory from sourceSets["test"] in build.gradle.kts, since testAnnotationProcessor already exposes it to compileTestJava and this extra srcDir is redundant. Update the test source configuration around sourceSets["test"] so the generated path is no longer added there; if IDE recognition is needed, register that directory as a generated source root instead.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@sdks/java/build.gradle.kts`:
- Around line 81-83: Remove the generated test sources directory from
sourceSets["test"] in build.gradle.kts, since testAnnotationProcessor already
exposes it to compileTestJava and this extra srcDir is redundant. Update the
test source configuration around sourceSets["test"] so the generated path is no
longer added there; if IDE recognition is needed, register that directory as a
generated source root instead.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: c7ee9fd1-9b04-4c4b-8ac9-76e115bededa
📒 Files selected for processing (1)
sdks/java/build.gradle.kts
…ssor generated sources
14d5d01 to
3ae5f38
Compare
1 participant
…ssor generated sources
Summary by CodeRabbit